Sean Heelan

Some additions

8

This is awesome! Some minor additions (as a disclaimer, I worked on all of these projects, but I feel they're worth mentioning nonetheless as the first is, to the best...

Consider supporting map definitions in a section that names the map

2

At the moment the `read_elf` function contains the following: ``` 50 vector read_elf(const std::string& path, const std::string& desired_section, const ebpf_verifier_options_t* options, const ebpf_platform_t* platform) { ... 64 ELFIO::section* maps_section =...

After removing the -std=c89 requirement mentioned in issue #8 I compiled the code and ran the produced test binary. The following happens: ``` $ ./test test: test.c:172: test_iterating: Assertion `strncmp((char...

``` $ make cc -std=c89 -pedantic -Wall -Wextra -Werror -ggdb3 -O0 -c test.c -o test.o test.c: In function ‘test_fill_with_deleted_items’: test.c:201:5: error: ‘for’ loop initial declarations are only allowed in C99...

rb_tree_insert_node doesn't return a success indicator correctly

1

The function starts as follows: ``` 232 // Returns 1 on success, 0 otherwise. 233 int 234 rb_tree_insert_node (struct rb_tree *self, struct rb_node *node) { 235 int result = 0;...