Sean Cassiere

Results 190 comments of Sean Cassiere

@keifufu I appreciate the snippet you posted is not just for aesthetic purposes, but I think I may be missing something for the request object being held intact. Could you...

> @SeanCassiere The request doesn't get stripped anymore because we don't clone it (or spread, or anything). We just pass the reference from fastify. > > I can't do any...

Came over to the repo because of the React 18 blocker and I'm realising that this package seems to be dead in terms of maintenance, but clearly **NOT** in usage....

> #2166 + [#1399 (comment)](https://github.com/warpdotdev/Warp/issues/1399#issuecomment-1397031223) would provide the desired functionality, I believe. I assume you mean manually setting the window dimensions yes?

Tanner's pattern of [validating the router search params](https://github.com/TanStack/router/blob/beta/examples/react/kitchen-sink-multi-file/src/routes/dashboard/users/index.tsx#L30-L37), could be something to consider here. The process in t3-env would look like this. 1. Make the `client` and `server` keys in...

Maybe consider using [date-io](https://github.com/dmtrKovalenko/date-io#projects), to allow for any date library to be usable. As such, people could use adapters like luxon, date-fns, dayjs, or even a custom one. Date-io is...

This has been fixed and released. You can get these changes on version [1.26.4](https://github.com/TanStack/router/releases/tag/v1.26.4).

Looks like this got fixed in #1189

Thanks for the catch @mgcrea! I'm going ahead and closing this one as it got fixed in #1189.

This was fixed in the [1.22.5](https://github.com/TanStack/router/releases/tag/v1.22.5) release.