Sean DuBois comments

Results 605 comments of


                                            Sean DuBois

Turn Stream.WriteSCTP() and Write() a blocking call by default

Should we make it part of pion/webrtc@v4 ? We can start a v2 now!

Turn Stream.WriteSCTP() and Write() a blocking call by default

@enobufs has also had ideas for RACK. This is a good chance to redo those parts that you have been debugging!

Lost connectivity after successful connection

This sounds similar to https://github.com/pion/webrtc/issues/2767 Thank you @paullouisageneau I will fix that and send you the PR. I bet that will improve QoS a bit :)

failed to resolve: could not find `dxdup` in `source`

I will look into this tonight! Broadcasting only works on Windows today, but playback is portable. Thanks for trying and filing :)

failed to resolve: could not find `dxdup` in `source`

That's amazing @ash30 I am so excited to get your help :) I made you an admin. Please upstream everything. I am happy to review/try things, but I don't even...

failed to resolve: could not find `dxdup` in `source`

@ash30 of course! Since you are doing the work do w/e you want! I am in support of whatever way you want to take the project.

Add an RTX-associated TrackLocal

Thank you @kevmo314! I cherry picked things and continuing it here https://github.com/pion/webrtc/pull/2676

SetReadDeadline causes nil pointer dereference

Hi @thanhpk How can I reproduce this? We have some simple tests, but I wasn't able to make it happen again.

Use Sync.Pool throughout for buffers

Yes please @adriancable ! We have usage in other places through out the code base. I am all for adding more

add shutdown to close

@craymond12 Do we not do a graceful close currently without this?