webrtc icon indicating copy to clipboard operation
webrtc copied to clipboard

SetReadDeadline causes nil pointer dereference

Open thanhpk opened this issue 1 year ago • 1 comments

Your environment.

  • Version: v4.0.0-beta.29
  • Browser: include version
  • Stacktrace
/vendor/github.com/pion/webrtc/v4/srtp_writer_future.go:108
/vendor/github.com/pion/webrtc/v4/rtpsender.go:435

What did you do?

Call rtpSender.SetReadDeadline(t)

What did you expect?

Don't panic

What happened?

Panic

This line causes the panic https://github.com/pion/webrtc/blob/master/srtp_writer_future.go#L108

I dont familiar with the project source code, but shouldn't you must call Store before call Load ?

thanhpk avatar Aug 25 '24 17:08 thanhpk

Hi @thanhpk

How can I reproduce this? We have some simple tests, but I wasn't able to make it happen again.

Sean-Der avatar Oct 07 '24 16:10 Sean-Der