Sean DuBois

Results 605 comments of Sean DuBois

@kleky Don't worry about adding `TCP` support to vnet. I don't think that blocks us getting this in at all. It is useful for testing how things behave in different...

@kleky I added both of you to the `pion` organization. You can push a branch directly here! That will make it a lot easier for us all to work together...

This is a pretty big paradigm shift, but we will make it work :) Feel free to refactor/change aggressively as well. I will work on getting test coverage up higher...

I can do all the server work! If you can get the client + tests passing with coturn, I can then point them against the server and implement everything.

oof, yes! I am thinking the right thing to do here is return. We can't read again right? I never actually reproduced this myself, sorry I should have put more...

Fantastic work @seankhliao! > what kind of tests to add? I don't have any hard rules, but if you can get ~80% coverage that would be great! I usually like...

crap sorry I missed this @seankhliao! Holy crap that is amazing progress! * I am not sure about portability issues, but it would probably be a blocker :( I will...

Nice catch! I think a better error message here would be fantastic. I am unsure if it is a good idea to support no authentication. I don't want to suggest...

@songjiayang I would really love to see this implemented! Have you done any research in how to handle UDP messages in high performance scenarios? It seems like this could be...

This is amazing! Nice work @seankhliao I am reviewing now :) I don't have access to a computer for another day or two so will be slower then usual sorry...