turn icon indicating copy to clipboard operation
turn copied to clipboard

Published 20 hours ago • verified publisher icon pion

RFC6062 TURN TCP allocations

Open seankhliao opened this issue 5 years ago • 5 comments

Description

Implements both client and server side support for TCP allocations and connections to peers.

Things to do:

  • [ ] tests, what to test?
  • [ ] add example(s)
  • [ ] review/break out use of syscalls for port reuse
  • [ ] review double lookup internal/server/turn.go

Reference issue

Fixes #143, #118

seankhliao avatar Jul 29 '20 21:07 seankhliao

Great to see you've implemented TCP support! I'll definitely test this within a couple of weeks.

Edit: Oh wait. I thought seankhliao was Sean from reddit. But that's Sean-Der. Anyways, great work! 👍

GingerAdonis avatar Jul 30 '20 06:07 GingerAdonis

This is amazing! Nice work @seankhliao I am reviewing now :)

I don't have access to a computer for another day or two so will be slower then usual sorry :(

Sean-Der avatar Aug 02 '20 21:08 Sean-Der

@Sean-Der is there anything I can do to help this get merged? 🙌

kylecarbs avatar Apr 21 '21 03:04 kylecarbs

@Sean-Der Did you get around testing these changes?

GingerAdonis avatar Dec 13 '21 13:12 GingerAdonis

Bump. This is a highly useful PR.

GingerAdonis avatar Apr 20 '22 13:04 GingerAdonis

I'm going to close this as:

  1. I've lost all context for this
  2. the underlying codebase seems to changed quite a bit

If anyone wants to work on this, feel free to base it off this code (if it's still useful)

seankhliao avatar Feb 03 '23 22:02 seankhliao