Scott Dugas

You may note that this does not include `PRIMARY_KEY_SEGMENT_INDEX_ENABLED`, that code broke with the tests because it tries to cast the `StoredFieldsReader`, but the reader is wrapped by the test...

FDBDirectory.openInput should throw `FileNotFoundException` or `NoSuchFileException`. The javadoc from lucene says it should throw `FileNotFoundException` or `NoSuchFileException` but we currently do not: https://lucene.apache.org/core/8_11_2/core/index.html

Additional diagnostics

11

Trying to get information regarding issue #2671

Add a lucene test that saves all possible unicode characters

4

Just to make sure it doesn't break

Surprising and inconsistent behavior depending on default locale

3

Some of the code in the record layer changes behavior based on the default locale of the system. Most of this does not seem intentional.

LuceneIndexMaintenanceTest > flakyMerge(true, true, true, 5, -3487483610997135943, false) fails

1

``` LuceneIndexMaintenanceTest > flakyMerge(boolean, boolean, boolean, int, long, boolean) > com.apple.foundationdb.record.lucene.LuceneIndexMaintenanceTest.flakyMerge(boolean, boolean, boolean, int, long, boolean)[6] FAILED org.opentest4j.AssertionFailedError: Group: (0), partition: 0 ==> expected: but was: at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at app//org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)...

FDBLuceneQueryTest.threadedLuceneScanDoesntBreakPlannerAndSearch normally takes a few seconds.

Make Lucene @Nightly tests pass for fixed seed

1

Not all of these tests pass, but it would be good if they did.