fdb-record-layer icon indicating copy to clipboard operation
fdb-record-layer copied to clipboard

Enable PrimaryKeySegmentIndex in Lucene test for Stored Fields

Open ScottDugas opened this issue 1 year ago • 0 comments

          You may note that this does not include `PRIMARY_KEY_SEGMENT_INDEX_ENABLED`, that code broke with the tests because it tries to cast the `StoredFieldsReader`, but the reader is wrapped by the test framework.

https://github.com/FoundationDB/fdb-record-layer/blob/a1e93d2dc293877c8bb200783f5c5a81ef6ead1d/fdb-record-layer-lucene/src/main/java/com/apple/foundationdb/record/lucene/LucenePrimaryKeySegmentIndex.java#L219

We may want to change the way that code works to work with the tests, but I think it makes sense to try and get the test framework in and then work to test it with more situations.

Originally posted by @ScottDugas in https://github.com/FoundationDB/fdb-record-layer/pull/2386#discussion_r1412613400

ScottDugas avatar Dec 12 '23 20:12 ScottDugas