Enno G.

Results 399 comments of Enno G.

After a review I would extend the commit descriptions and remove the TODOs from the test docstrings. If no review is possible today I will do so on Monday.

All TODOs in the file that I added were filled and the Git commits should have improved commit messages. The PR is ready for merge now after approval by someone...

Too many tests are failing. I will have a look during the weekend what I can do about that...

Now all tests are passing (including LDAP tests). The CI is failing since Codacy refuses to acknowledge the set secret for uploading the report. This is due to #3379.

The important part of the documentation for us are: - https://cloudinit.readthedocs.io/en/latest/topics/datasources/nocloud.html#nocloud - https://cloudinit.readthedocs.io/en/latest/topics/network-config.html Edit if we want to pass scripts we should remind ourselves of the following: https://cloudinit.readthedocs.io/en/latest/topics/format.html#user-data-script

Since I want to get rid of Cheetah long term I will use Jinja templates for this feature. This means validating that #1605 is no longer valid or fix it.

We should be able to make use of the new URL structure in a backwards compatible way with `**rest` parameter that is currently unused. The dict is filled by `__fillup_form_dict`....

XML-RPC has no concept of kwargs. This makes adding the options as optional arguments really verbose. Details see here: https://stackoverflow.com/a/120291

@easpeagle You can see that there is a WIP PR linked. In the merge order, this is in the fourth place. Progress is there but not very fast due to...

@easpeagle It is very nice to see your interest in the Pull Request. However, it is not in a state where you could test it sadly. The current merge order...