require either local or remote kernel+initrd

[olafhering]

Fixes #2883

Signed-off-by: Olaf Hering [email protected]

[codecov[bot]]

Codecov Report

Patch coverage: 77.12% and project coverage change: +58.44 :tada:

Comparison is base (5b83e4d) 0.19% compared to head (8baaf0c) 58.63%.

:exclamation: Current head 8baaf0c differs from pull request most recent head ef68d21. Consider uploading reports for the commit ef68d21 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##            main    #2884       +/-   ##
==========================================
+ Coverage   0.19%   58.63%   +58.44%     
==========================================
  Files         92      101        +9     
  Lines      13024    14414     +1390     
==========================================
+ Hits          25     8452     +8427     
+ Misses     12999     5962     -7037     

Impacted Files	Coverage Δ
cobbler/cexceptions.py	100.00% <ø> (+100.00%)	:arrow_up:
cobbler/cobblerd.py	0.00% <0.00%> (ø)
cobbler/modules/authentication/denyall.py	75.00% <ø> (+75.00%)	:arrow_up:
cobbler/modules/authentication/pam.py	90.47% <ø> (+90.47%)	:arrow_up:
cobbler/modules/authentication/passthru.py	100.00% <ø> (+100.00%)	:arrow_up:
cobbler/modules/authentication/spacewalk.py	23.68% <ø> (+23.68%)	:arrow_up:
cobbler/modules/authorization/allowall.py	75.00% <ø> (+75.00%)	:arrow_up:
cobbler/modules/authorization/configfile.py	32.00% <ø> (+32.00%)	:arrow_up:
cobbler/modules/authorization/ownership.py	11.11% <ø> (+11.11%)	:arrow_up:
cobbler/modules/installation/post_log.py	82.35% <ø> (+82.35%)	:arrow_up:
... and 90 more

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[SchoolGuy]

@watologo1 What is your status on this? We talked on the phone and you had a concept in mind to fuze both parameters.

[SchoolGuy]

@watologo1 Ping?

[SchoolGuy]

@watologo1 Ping again. Any opinion?

[olafhering]

One more review required to get enable the Merge knob. I think this change is not controversial.

[SchoolGuy]

@olafhering My requested changes are still not addressed from before the rebase. What are we going to do about them?

[olafhering]

I have no resources to do further work in this specific bug.

[SchoolGuy]

@olafhering Okay thanks for the clarification. I will try to finish the PR then.

[SchoolGuy]

Rebase onto main. I will try to take care of this once #3411 and #3333 are merged.

[SchoolGuy]

I will now start actively working on this. This PR will need new tests that the desired behaviour is working as intended.

[SchoolGuy]

Please do NOT merge this PR until I took it out of a Draft state. @watologo1 will test this internally and after this was successful I desire to extend the commit descriptions.

[SchoolGuy]

After a review I would extend the commit descriptions and remove the TODOs from the test docstrings. If no review is possible today I will do so on Monday.

[SchoolGuy]

All TODOs in the file that I added were filled and the Git commits should have improved commit messages. The PR is ready for merge now after approval by someone else than me.

[SchoolGuy]

Too many tests are failing. I will have a look during the weekend what I can do about that...

[SchoolGuy]

Now all tests are passing (including LDAP tests). The CI is failing since Codacy refuses to acknowledge the set secret for uploading the report. This is due to #3379.