Rudolf Schneider

ArticleIndexFactory.loadWikiDataIndex causes java.lang.IllegalArgumentException: Prefix string too short if a InternalResource is passed

2

If you call `de.datexis.index.ArticleIndexFactory.loadWikiDataIndex()` with an InternalResource created with `Resource.fromJAR()` as `cacheDir` an `java.lang.IllegalArgumentException: Prefix string too short` exception is thrown. Generally, this is a bad idea to do, but...

ObjectSerializer causes "java.lang.IllegalStateException: zip file closed" if called for the first time in a parallel stream

3

ObjectSerializer causes `java.lang.IllegalStateException: zip file closed` if called for the first time in a parallel stream. This is caused by the reflections scan of the jar which is not thread-safe....

The optimaize language-detector uses a [quite old guava version](https://github.com/optimaize/language-detector/blob/1a322c462f977b29eca8d3142b816b7111d3fa19/pom.xml#L231) which conflicts with guava 23.0 which is used by [sszuev/fastText_java](https://github.com/sszuev/fastText_java/blob/b7da617478ce7e5c5aba9704828381682f85eec4/pom.xml#L230). ``` Caused by: java.lang.NoSuchMethodError: com.google.common.collect.ImmutableList.copyOf(Ljava/util/Collection;)Lcom/google/common/collect/ImmutableList; at com.optimaize.langdetect.profiles.BuiltInLanguages.(BuiltInLanguages.java:92) at com.optimaize.langdetect.profiles.LanguageProfileReader.readAllBuiltIn(LanguageProfileReader.java:118) at de.datexis.preprocess.DocumentFactory.(DocumentFactory.java:79)...

This test has no assertion and is just logging things to console. We should consider changing this. Additionally, the method name is not well expressing what is tested. https://github.com/sebastianarnold/TeXoo/blob/32f13a1d420d5a2c2407593a68a7cc0e8d5c484c/texoo-entity-linking/src/test/java/de/datexis/nel/NamedEntityAnnotatorTest.java#L43-L55