Erik Schamper

Results 158 comments of Erik Schamper

We don't really support casting, no. The new v4 (#35) should make this easier/possible, but it's not a feature as of yet.

I don't think we should change the default for `align`, a lot of things will break. The most common use-case for `dissect.cstruct` is probably eyeballing hexdumps and unpacking (usually tightly...

This is unfortunately a known limitation of the current parser. Would love to support this since I also regularly run into this issue. Not sure how feasible it is with...

This is related to https://github.com/fox-it/dissect.cstruct/pull/44, however I'm rewriting this to be compatible with the upcoming cstruct v4 (https://github.com/fox-it/dissect.cstruct/pull/35). I'm close to a satisfying solution but ran into some minor roadblocks...

This should be fixed with #49 and #35.

> Thanks for the additional review! It seems like we are still left with the following `tox -e docs-build` warnings. The last two we can fix, the first two are...

I don't really understand how it works either :smile: @Miauwkeru can you comment on the above regarding the `EtcPlugin`?

Depends on #832 for the `/etc/pve/qemu-server` symlink to function.

Test file uploaded in a separate PR because of annoying GitHub bugs with LFS on PR branches: https://github.com/fox-it/dissect.target/pull/833

Will be continued at #837