Erik Schamper

Results 158 comments of Erik Schamper

The `DirectoryFilesystemEntry.get()` method calls `self.fs.get()`, I'm not sure what you mean? If you put it in `DirectoryFilesystem.get()`, it should work universally. My idea was to maybe have some kind of...

Wouldn't this also be an issue on non-zip (directory) Velociraptor targets?

We don't use Velociraptor so I can't really speak for it, but I do think I've heard people say they sometimes work with unzipped collections. If there are no other...

After a short discussion we decided it may be best to tweak the `ZipFilesystem` and `DirectoryFilesystem` implementations slightly to facilitate customization by subclasses a little better. You can then subclass...

I've made some suggestions for how I envisioned the filesystem thing to work. I'll leave fixing the unit tests up to you :wink:.

I didn't verify (can try later if needed) but my guess is it's because of the blanket `.replace(".", "%2E")`, which will also replace periods which aren't encoded as `%2E` in...

@Zawadidone the unit tests are still failing.

I am working slowly through the backlog of long outstanding PRs but had not gotten to this yet. Your proposal of splitting it up sounds like a good idea though,...

Hi @R3dP1ll, are you still interested in continuing this PR?