Sebastian Scheinkman comments

Results 287 comments of


                                            Sebastian Scheinkman

FailedCreatePodSandBox from kubelet with error: plugin type="multus-shim" name="multus-cni-network" failed (add): CmdAdd (shim): CNI request failed with status 400:

Hi @jaecrane @NieShiyang any update on this one or we can close the issue?

🌱 Making workflows not run on forks.

+1 from my side to not add this. you can just disable github actions on your fork. also it introduce an issue on the device plugin so if possible I...

cmdDel fails releasing the device when kubelet deletes pause container

Hi @YitzyD @blackgold question can you share your pod yaml? just to be sure are you using ` terminationGracePeriodSeconds: 0` ?

cmdDel fails releasing the device when kubelet deletes pause container

Also with container runtime are you using? I try this with crio and I am not able to reproduce the issue after using https://github.com/k8snetworkplumbingwg/sriov-cni/pull/220

Basic E2E test, utils implementation and scripts to setup KinD cluster

@Eoghan1232 will it be possible to rebase this PR to fix the merge issues?

Basic E2E test, utils implementation and scripts to setup KinD cluster

can we close this one in favor of https://github.com/k8snetworkplumbingwg/sriov-cni/pull/282?

Move allocated pci deletion in defer of del cmd

Hi @mlguerrero12 thanks for the comment! the thing is that if we failed on moving back the vf because of an issue (and we already encounter some of them) it...

Move allocated pci deletion in defer of del cmd

I get your point. but for this to work I think we need also another step we need to change the places where we are creating a new `err` variable...

Move allocated pci deletion in defer of del cmd

Hi @mlguerrero12 thanks for the comment! you are right maybe we can add a better comment for this. another use-case is the protection if for some reason the cniDel failed....

sriov-cni v2.6.2 container image security vulnerabilities

@rollandf should we just switch the image to centos or something else?