sriov-cni
sriov-cni copied to clipboard
Published
20 hours ago •
k8snetworkplumbingwg
k8snetworkplumbingwg
🌱 Making workflows not run on forks.
This PR is making sure that github workflows only run on upstream repo and not on forks.
Pull Request Test Coverage Report for Build 8966234367
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 47.514%
| Totals | |
|---|---|
| Change from base Build 8835333415: | 0.0% |
| Covered Lines: | 602 |
| Relevant Lines: | 1267 |
💛 - Coveralls
similar PR didn't work on sriov-device-plugin https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/actions/runs/9091929799
/hold
a few comments on why we might not want this:
- you can disable actions on fork
- actions run against master and v* tags, on a normal dev flow you create some branch like "fix-something" then push to it. actions should not run on it.
- you may want to develop actions on your fork so in this case its beneficial for them to run on the fork for testing.
what is the reason to have this change ?
+1 from my side to not add this. you can just disable github actions on your fork. also it introduce an issue on the device plugin so if possible I will not like to add more complexity to our release pipeline :)
