Saumya Shah

Results 14 comments of Saumya Shah

> ## Tasks > * [ ] currently all CIT workflows are independent. In order to be able to have a final job once all CIT jobs are finished we...

@GiedriusS (regarding `FuzzNodesMarshalJSON` test fail..) The problem might be with `promqlsmith` about how its generating queries based on seed values. Sometimes, the test passes but in certain cases like below:...

> Sorry I don't see it - isn't that valid Syntax? Of what I searched upon, shouldn't there be any arguments with `count_values`? Also `--` within that expression.. (I'm sorry...

> Nah that's actually valid PromQL - first argument of count values says which label names values to count, -- is twice unary negation. As far as I can see...

> > Nah that's actually valid PromQL - first argument of count values says which label names values to count, -- is twice unary negation. As far as I can...

Err I was on different go version (1.24) locally so didnt saw the same error. Fixed now

Test seems to be failing for few cases locally ``` enginefuzz_test.go:274: load 2m http_request_duration_seconds{pod="nginx-1"} {{schema:0 count:3 sum:14.00 buckets:[1 2]}}+{{schema:0 count:4 buckets:[1 2 1]}}x20 http_request_duration_seconds{pod="nginx-2"} {{schema:0 count:2 sum:14.00 buckets:[2]}}+{{schema:0 count:6 buckets:[2...

> Looks like the problem in the first case is that the compare logic doesn't know about histograms. I can try to push a fix for that today. comparer does...

Thanks It should be passing all cases now ig. Only falling one remaining is `last_over_time` ``` enginefuzz_test.go:274: load 2m http_request_duration_seconds{pod="nginx-1"} {{schema:0 count:3 sum:14.00 buckets:[1 2]}}+{{schema:0 count:83 buckets:[1 2 80]}}x20 http_request_duration_seconds{pod="nginx-2"}...