Sascha Schwarze

Results 25 issues of Sascha Schwarze

I extended the GitHub action to run gosec as part of a build. I mitigated the one finding: * In checkpoint.go there was a `Atoi` followed by a cast to...

# Changes The Knative controller infrastructure uses by default two threads per controller. This setting is not configurable in Knative itself while [Tekton allows to configure it](https://github.com/tektoncd/pipeline/blob/v0.38.2/cmd/controller/main.go#L46). [I was playing...

size/XS
needs-ok-to-test
kind/enhancement

Run stopSidecar logic even if TaskSpec has no sidecars to support injected sidecars such as istio-proxy Signed-off-by: Sascha Schwarze # Changes Sidecars in a Tekton pod can be declared in...

kind/bug
size/XS
do-not-merge/work-in-progress
ok-to-test
release-note

I was hunting down a performance issue that we are seeing when Knative is reconciling all revisions, for example due to the controller being restarted or global syncs. The problem...

kind/bug
triage/accepted

We are happily using BuildKit and would like to continue doing so. For this, we need it to pass `gosec -confidence medium -severity high`. Let me know if the BuildKit...

status/design-review

Fixes #14669 ## Proposed Changes * This changed the Knative PodAutoscaler logic to never change the DesiredScale from a non-negative to a negative value. * This happens when leading AutoScaler...

area/API
size/L
lgtm
do-not-merge/hold
area/autoscale
ok-to-test

When restarting the autoscaler component, then Knative keeps itself busy for a while. For every PodAutoscaler that is related to an active revision, I see this happening: 1. The PodAutoscaler...

kind/bug
area/autoscale

/area autoscale ## Describe the feature In [Bubble up pod schedule errors to revision status](https://github.com/knative/serving/pull/4191), the Revision reconciler was changed to propage pod scheduling issues up to the Revision. This...

kind/feature
area/autoscale

### Is there an existing feature request for this? - [X] I have searched the existing feature requests ### Is your feature request related to a problem or use-case? Please...

kind/feature

At the moment, many files in this repository do not have a copyright header. This needs to be fixed. Ideally, we also have an action that verifies the presence of...

kind/cleanup