Saransh Chopra
Saransh Chopra
I feel that the solution implemented in the CI right now looks good enough. I have never switched documentation link to a specific tag for PyPI, so I don't have...
I have been looking into the code and the paper, and I think it would be best to have a separate JAX implementation for the function. The array mutations are...
cc: @ntessore
The .cff format will enable copy-pastable citation in a dropdown menu on github, offering both APA and BibTex formats - This has become a standard for software citations, but I'll...
Oh I see, .bib sounds good then!
Having a BibTex entry in the README and a `.cff` file to enable GitHub's feature sounds better imo. PyBaMM ([BibTex in README](https://github.com/pybamm-team/PyBaMM?tab=readme-ov-file#-citing-pybamm), [.cff file for GitHub](https://github.com/pybamm-team/PyBaMM/blob/develop/CITATION.cff)) does the same too....
@agriyakhetarpal this PR needs tests and we agreed that the notebook is a great starting point for that, so the current notebook content should just be copy-pasted (and modified) as...
Also, all the instances of `assert all(numpy_array == numpy_array)`/`assert np.allclose(numpy_array == numpy_array)` (if we have any) should be replaced with `numpy.testing` calls.
I spent some time on this, and we really can't do anything till there is a typing `Protocol` (or a superclass for typing purposes which is subclassed by every Array...
https://github.com/data-apis/array-api-typing 👀