Saransh Chopra comments

Results 248 comments of


                                            Saransh Chopra

Unified entry point for models and parameter sets

Thanks for the detailed explanation, @agriyakhetarpal! Everything is very clear now.

Unified entry point for models and parameter sets

Still shows "Merging is blocked" :( I think it needs an approval from @kratman and @valentinsulzer as they have requested changes above.

Add missing docstring examples

Thanks! Let me know if any help is required!

New package: cuda-histogram

Sorry I am a bit inactive from work this week, but I will look into the comments soon. Thanks for all the help @matthewfeickert and @jakirkham, really appreciate it!

New package: cuda-histogram

Being fixed in https://github.com/conda-forge/mplhep_data-feedstock/pull/5

Improvements to plotting functionality

I think a portion of `create_gif` does act as the proposed `QuickPlot.plot`. We can maybe refactor this method to make way for the new method - https://github.com/pybamm-team/PyBaMM/blob/e730dcb7cfc7c6da595618502d4e026378c0d4f4/pybamm/plotting/quick_plot.py#L745-L772

Array API: remove array mutation from functions/write JAX version of each array mutating function

For array mutations, we can either rewrite functions to build copy of the original arrays, or we can write a separate implementation for `jax` (using the [`at` syntax](https://docs.jax.dev/en/latest/_autosummary/jax.numpy.ndarray.at.html)). The `at`...

Array API: remove array mutation from functions/write JAX version of each array mutating function

Ideally should be generic, but no worries if things have specialized implementations (we are not worried a lot about the JIT support) -- just add a dispatching mechanism to hide...

sp_repo_review: false positive and false negative mypy checks

Thank you! But, I still see the same results for some reason.