Sapein
Sapein
I would be willing to help out with this, but I'm afraid I'm not that familiar with how the bindings are generated to really be that much help
It wouldn't necessarily integrate or cause any issues, strictly speaking, although github doesn't necessarily seem to integrate with it (which is fair enough). If someone creates a github repository from...
> Looks good to me, we can add the `Custom` variant if necessary in another PR Apologies for that btw. I was working on it while you were reviewing and...
I'm not against `CommonScreenResolution`, but something about it doesn't feel quiet right to me tbh, although I'm not against it as it is a better name than `Resolution` especially given...
> I quite like this: this is a utility that almost every game will want. To make this better: > > 1. More doc comments, explaining why this is useful....
Fair enough. I'll go ahead and implement `From for WindowResolution` as well, and leave the Default for now, it was mostly just something I thought of as a bit more...
> A nice Display implementation for use in menus that shows "1920 x 1080" and so on. Would we want it to display "w x h" or something like the...
> Breadcrumbs to this in at least one example: probably window_settings or game_menu. I would really love to wire this up to a settings menu but that might be too...
Should I add in an 800x600 resolution as well? It seems like many examples use that resolution as well. So it might be useful to implement that resolution as well.
> @Sapein that's just [SVGA](https://en.wikipedia.org/wiki/Graphics_display_resolution#SVGA), right? Pretty sure the examples just used some arbitrary resolution, so there's no harm to changing it to something like 720p or HD. > >...