Sanne Grinovero

Results 140 comments of Sanne Grinovero

Hi @technical-debt-collector - I'm referring to our experiments with the Techempower benchmarks; you can easily run them yourself, would be great to have some more eyes on these: - https://github.com/TechEmpower/FrameworkBenchmarks...

I fixed the issue in the vertx tests, which were making assumptions about the number of threads we'd be starting. But now there's some new tests failing, Windows only -...

so you're searching like `is:pr is:open "io.quarkus.it.opentelemetry.vertx.HelloRouterTest.bus" ` ? I couldn't find any previous similar failure; I assume you're referring to the other failure? in that case it's fairly ancient,...

I've finally been able to run tests on a local Windows box - of course they don't fail here :(

The remaining two failures seem to be frequent offenders, so I think this is ready to be merged.

> Is it because native build do not remove all unused classes and methods and every new jar dependency will just add own size to the final binary? Even if...

@vjovanov in Quarkus we make sure many immutable structures that frameworks needs are initialized as a constant during compilation, so for example many such String and HashMap are "ready to...

@dougxc great point, I hadn't thought of that. Regarding - specifically - Strings, I think we can all agree that people should never do this, but I agree it could...

Hello, please don't enable `--allow-incomplete-classpath`, it makes building large projects extremely difficult - especially if one wants to produce a reliable application (don't we all want that?). Also, regarding "since...

@christianwimmer that makes sense, thank you! If we can simply revert to the current semantics I see no problem; we already do the same for e.g. not discovering all Services...