quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Reduce the number of vert.x eventloops started by default

Open Sanne opened this issue 3 years ago • 10 comments

As discussed at JNation, we have some experiments showing that:

  • there's no compelling reason to start more eventloops than available cores
  • it's actually harmful for performance in some cases

And obviously it saves a little chunk of memory as well. We briefly discussed the possibility to create "named profiles" so that people could experiment with different scaling formulas, but we decided to keep it simple: this is just the default meant to provide a reasonable OOB experience, while people wanting to tune things further can set the appropriate configuration property.

cc/ @franz1981

Sanne avatar Jul 29 '22 12:07 Sanne


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 4cb0eec32f082bc37243ce9ac68af1459a22f6f9

Status Name Step Failures Logs Raw logs
:heavy_check_mark: Devtools Tests - JDK 11
Devtools Tests - JDK 11 Windows Build Failures Logs Raw logs
:heavy_check_mark: Devtools Tests - JDK 17
Gradle Tests - JDK 11 Build Failures Logs Raw logs
:heavy_check_mark: Gradle Tests - JDK 11 Windows
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools 

:package: integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testExampleCodestartsKotlin(String)[1] line 100 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testExampleCodestartsKotlin(String)[1] line 100 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

:gear: Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

:package: integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

:gear: JVM Tests - JDK 11 #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 334 more

:package: extensions/vertx/deployment

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

:gear: JVM Tests - JDK 11 Windows #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 334 more

:package: extensions/vertx/deployment

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

:gear: JVM Tests - JDK 17 #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 334 more

:package: extensions/vertx/deployment

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

:gear: JVM Tests - JDK 18 #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 334 more

:package: extensions/vertx/deployment

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

quarkus-bot[bot] avatar Jul 29 '22 14:07 quarkus-bot[bot]

This is really interesting. @Sanne, are the experiments available somewhere? I found some JNation videos but couldn't find anything on this.

Imo this is an important topic with generally too little information available - there's hardly anything beyond the description of the config parameter. If there's reason to either adjust the configuration or leave it alone, then I think developers should know about it. In our case we now have two reactive applications, one of which cannot be run with multiple instances - and we've upped the event loop pool size for the latter :)

Vert.x still runs with the 2 x core-default. Do the guys over there know about these experiments? https://github.com/eclipse-vertx/vert.x/blob/428f2fd0966057eb9f0e83f70ada8dc08c092a0a/src/main/java/io/vertx/core/VertxOptions.java

Hi @technical-debt-collector - I'm referring to our experiments with the Techempower benchmarks; you can easily run them yourself, would be great to have some more eyes on these:

  • https://github.com/TechEmpower/FrameworkBenchmarks

Specifically the code we were looking into is in:

  • https://github.com/TechEmpower/FrameworkBenchmarks/tree/master/frameworks/Java/quarkus

We discuss some of these things in a recent Quarkus Insights as well:

  • https://youtu.be/m_UmdIqDXg0

Yes I know about the vert.x defaults - we're talking and working with the vert.x team as well, however since that's more exposed in that case one might not want to make such a change in a minor release; in Quarkus however we think it's safe enough.

BTW I'll be out of town for some days - might be slow to follow up :) @franz1981 knows more about this though, feel free to discuss here.

Sanne avatar Jul 31 '22 20:07 Sanne

The CI failures seem related

geoand avatar Aug 01 '22 05:08 geoand

Thanks @Sanne! I'll have a look at this as soon as I find the time, possibly not before EOW.


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 1f604ac07992be8b529d3458358f695d309b09a1

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: JVM Tests - JDK 11 #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 334 more

:package: extensions/vertx/deployment

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

:gear: JVM Tests - JDK 11 Windows #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 334 more

:package: extensions/vertx/deployment

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

:gear: JVM Tests - JDK 17 #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 334 more

:package: extensions/vertx/deployment

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

:gear: JVM Tests - JDK 18 #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 334 more

:package: extensions/vertx/deployment

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.deployment.MessageConsumerContextTest.testRequestReply line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <3> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

quarkus-bot[bot] avatar Aug 09 '22 13:08 quarkus-bot[bot]


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 8db536ee71f4d76c98f7aad4bbb9e759288c11f5

Status Name Step Failures Logs Raw logs
:heavy_check_mark: Devtools Tests - JDK 11
Devtools Tests - JDK 11 Windows Build Failures Logs Raw logs
:heavy_check_mark: Devtools Tests - JDK 17
:heavy_check_mark: JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 17
:heavy_check_mark: JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

:gear: Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools 

:package: integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsScala line 74 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testExampleCodestartsJava(String)[3] line 94 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsScala line 74 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testExampleCodestartsJava(String)[3] line 94 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

:gear: JVM Tests - JDK 11 Windows #

- Failing: integration-tests/opentelemetry-vertx 

:package: integration-tests/opentelemetry-vertx

io.quarkus.it.opentelemetry.vertx.HelloRouterTest.bus line 128 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <CONSUMER> but was: <PRODUCER>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

quarkus-bot[bot] avatar Aug 09 '22 19:08 quarkus-bot[bot]

I fixed the issue in the vertx tests, which were making assumptions about the number of threads we'd be starting.

But now there's some new tests failing, Windows only - I'll need to check those later. Does anyone have an effective way to check if these tests have been failing recently in other PRs ?

I'm puzzled about why this patch would break something only on Windows.

Sanne avatar Aug 09 '22 21:08 Sanne

I don't remember seeing this one failing. One way to be sure is to just do a search in the PR with the name of the test, given they are included in comments. That's one nice additional benefit of the reports.

And apparently, it also failed here: https://github.com/quarkusio/quarkus/pull/27210 .

gsmet avatar Aug 09 '22 22:08 gsmet

so you're searching like is:pr is:open "io.quarkus.it.opentelemetry.vertx.HelloRouterTest.bus" ?

I couldn't find any previous similar failure; I assume you're referring to the other failure? in that case it's fairly ancient, not sure if it should count.

Sanne avatar Aug 10 '22 13:08 Sanne

I've finally been able to run tests on a local Windows box - of course they don't fail here :(

Sanne avatar Aug 10 '22 21:08 Sanne

I just search for HelloRouterTest in the search box for instance.

gsmet avatar Aug 10 '22 22:08 gsmet

Failing Jobs - Building 9bf91d3fc4b2e15db06ef5601f14b14d3bc182ab

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
:heavy_check_mark: Gradle Tests - JDK 11 Windows
JVM Tests - JDK 11 Build Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 17
:heavy_check_mark: JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

:gear: Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

:package: integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

:gear: JVM Tests - JDK 11 #

- Failing: extensions/smallrye-reactive-messaging-amqp/deployment 
! Skipped: integration-tests/reactive-messaging-amqp 

:package: extensions/smallrye-reactive-messaging-amqp/deployment

io.quarkus.smallrye.reactivemessaging.amqp.SecuredAmqpTest.test line 28 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.smallrye.reactivemessaging.amqp.SecuredAmqpTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

quarkus-bot[bot] avatar Aug 11 '22 00:08 quarkus-bot[bot]

The remaining two failures seem to be frequent offenders, so I think this is ready to be merged.

Sanne avatar Aug 11 '22 10:08 Sanne