SandishKumarHN

Results 7 comments of SandishKumarHN

@vmoens can you review once, build errors on resource not related to the PR.

@vmoens address most of your comments above, but doctests are failing with below error not caused by this PR changes. ``` File "/home/sandish/rl/torchrl/objectives/cql.py", line 128, in cql.CQLLoss Failed example: loss...

@vmoens made changes based on your review, I still reduction is not being added to the test_cost.py file so all of the failures are related to that.

@polarathene would you mind I take the PR, test and commit to the repo ?

@justinchuby i will work on this, who is the right poc to ask questions if i get stuck?

Yes, in airflow task-id would be like this example-> sqoop_create_exec_{{ conf.source_database.name }}_{{ table.source.name }} and filenames would be same but .py or we can do like examples-> create_execute_sqoop_parquet_hdfs_impala.py and clean_sqoop_parquet_hdfs_impala.py

Kubectl can use existing images, so I need to arrange a salves images. the plan is to make cluster instead of standalone. we can keep same structure.