Sandakan Nipunajith
Sandakan Nipunajith
@ElectroHeavenVN, It feels cluttered and unnecessary to display the original lyric after it has been converted. I'll suggest a better way to go about this. 1. The original lyrics are...
@ElectroHeavenVN >The originalLanguage property does not always exist in the LRC file, so I cannot rely 100% on it. If it does not exist, you can use the functions you...
> I got it. I modified the code so that lyrics will be displayed in 1 line by default (no small line above and below main lyrics). I apologize if...
@ElectroHeavenVN, From your last commits, I think you still didn't quite get what I was saying. Consider this example  1. primary lyric 2. secondary lyric (primarily used with translations)...
@ElectroHeavenVN, > > In the `parseLyrics` function, > > > > 1. The original lyrics are displayed with the option to romanize them by checking the `originalLanguage` property. If the...
> No, I mean if I remove the `convertedLyrics` property and then set the `originalText` property with converted lyrics, when the lyrics are translated, the `unparsedLyrics` will be updated with...
@ElectroHeavenVN, https://github.com/Sandakan/Nora/blob/2accfef65aeaee560b9bcd5ee1f004b7927e64fe/src/common/parseLyrics.ts#L268 The above line shows an error in the IDE saying `Property 'pinyin' does not exist on type 'typeof pinyin'.`. I managed to get rid of the error in...
@ElectroHeavenVN, Can you also make sure the tests also work with the included changes for the parseLyrics function?
> I updated the test with additional properties, and it seems to run just fine, but in the app, when the lyric is loaded, the following exception is thrown and...
@ElectroHeavenVN, Nice. Can you create another pull request for it?