Sam Millman

Results 26 comments of Sam Millman

This point only actually applies to emails that get double routed internally, i.e. I send from [email protected] to [email protected] which then forwards to sammaye@my_awesome_personal_mail.com

I made a simple change in the way the from header is parsed and processed which seems to do the job: ``` javascript header = header.replace( /^From: (.*(?:\r?\n\s+.*)*)/mg, function(match, from)...

Ok, kool. Though adding "at" for emails routed through verified domains could be classed as slightly buggy which is what I found, since you wouldn't expect that, you would only...

Ok I have produced one and I was wrong, it does call my error handler, but it still says in Sentry that the instrument was the mechanism and it still...

[test.zip](https://github.com/getsentry/sentry-javascript/files/9557874/test.zip) Here is the code. Basically you will see in the global error handler I put a line like console.log('in error handler'); and this proves that it actually calls my...

Something else I have noticed there as well the stack trace is messed up, take this error from my live app https://sentry.io/organizations/delenta/issues/3586583907/?query=is%3Aunresolved where it easily shows what module it crashed...

As a note: I did make the test in angular 14 and not 10, which while proves it isn't my angular version also mean the stack trace difference is likely...

Ok further update, I thought I would test the scenario that does assign user for me in the new app and it doesn't: https://sentry.io/organizations/delenta/issues/3586723234/events/3eb54a8fbc26473f9e45326c22ba2212/?project=6736456&query=is%3Aunresolved and here is a screenshot of...

And here is an error of the same kind form my live app, no nodejs server running, but it attaches the user correctly https://sentry.io/organizations/delenta/issues/3586740920/?query=is%3Aunresolved and the only real difference I...