Sam Yuan

Results 244 comments of Sam Yuan

> Chaincode install talks directly to a specific peer so doesn’t use the Gateway service. It might not be possible to simplify that one. You could argue for a chaincode...

I am going to approve this PR, @samuelvenzi , any further comments?

As a personal suggestion, if @denyeart/ @bestbeforetoday can offline review this PR that would be fine. otherwise, @aldousalvarez , you'd better join fabric contributor meeting or other approach to contact...

``` ? github.com/hyperledger/fabric-admin-sdk/internal/channelconfig [no test files] ? github.com/hyperledger/fabric-admin-sdk/internal/configtxgen/encoder [no test files] ? github.com/hyperledger/fabric-admin-sdk/internal/configtxgen/encoder/fakes [no test files] ? github.com/hyperledger/fabric-admin-sdk/internal/configtxgen/genesisconfig [no test files] ? github.com/hyperledger/fabric-admin-sdk/internal/configtxgen/metadata [no test files] ? github.com/hyperledger/fabric-admin-sdk/internal/configtxgen/viperutil [no test...

``` ok github.com/hyperledger/fabric-admin-sdk/pkg/channel 0.469s coverage: 0.0% of statements ```

@channingduan , could you please take a look at this issue?

> Just for reference, the current set of linters being run (in addition to staticcheck) are: > > * errcheck > * gofmt > * goimports > * gosec >...

Hi @denyeart and @bestbeforetoday I would like to have you reviewed with current WIP part of code as if I am moving on, this pr will be too large to...

In my point of view, the reason for sleep: as the some operator need a block to delivered to each peer as conformation. hence the sleep is added to ensure...

> The chaincode API calls that submit transactions already waits for blocks to be committed before returning. This is handled by Fabric Gateway. Where channel API calls need to wait...