fabric-admin-sdk icon indicating copy to clipboard operation
fabric-admin-sdk copied to clipboard

Try to enable go lint with options

Open SamYuan1990 opened this issue 2 years ago • 4 comments

#- varcheck
  #- gocyclo
  #- bodyclose
  #- misspell
  #- nakedret
  #- unconvert
  # - goconst
  # - gocritic
  # - noctx
  # - whitespace
  # - dupl

to improve our code quantity with lint options above.

SamYuan1990 avatar Apr 16 '23 01:04 SamYuan1990

@channingduan , could you please take a look at this issue?

SamYuan1990 avatar Apr 16 '23 01:04 SamYuan1990

Just for reference, the current set of linters being run (in addition to staticcheck) are:

  • errcheck
  • gofmt
  • goimports
  • gosec
  • gosimple
  • govet
  • ineffassign
  • typecheck
  • unused

The active linters are configured in .golangci.yml. See the golangci-lint documentation for available linters.

bestbeforetoday avatar Apr 26 '23 14:04 bestbeforetoday

Just for reference, the current set of linters being run (in addition to staticcheck) are:

  • errcheck
  • gofmt
  • goimports
  • gosec
  • gosimple
  • govet
  • ineffassign
  • typecheck
  • unused

The active linters are configured in .golangci.yml. See the golangci-lint documentation for available linters.

thanks a lot for comments, updated scope.

SamYuan1990 avatar Apr 26 '23 15:04 SamYuan1990

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 08 '23 03:06 stale[bot]