Kristina

value of `client_id_scheme`...

1

The value of the `client_id_scheme` parameter MUST be `wallet_attestation`.

clarify wallet invocation when credential offer is sent

5

resolves issue #201.

AS can act as an Issuer?

2

Obviously very wrong how it is, so approving. Probably we should mention that the Credential Issuer may optionally also be an AS. _Originally posted by @jogu in https://github.com/openid/OpenID4VCI/pull/299#pullrequestreview-2024835394_

dark mode and light mode in the display of the credentials

2

@leecam pointed out that it would be nice to have a dark and light versions for any images or colors specified in the display object of a credential. Is there...

adding an optional `sub` claim in Key proof

4

The spec currently defines that an optional `iss` value in key proof `MUST be the client_id of the Client making the Credential request`. However, in many cases, keys to validate...

JSON schema for Issuer metadata?

5

should we add JSON schema for the issuer metadata in the appendix? I started one for non-credential format specific parts. [OID4VCI_metadata_json_schema.json](https://github.com/openid/OpenID4VCI/files/14255854/OID4VCI_metadata_json_schema.json)

using credential_configuration_id in the credential request when scopes are used in the authorization request

8

Currently, Credential Request has two options to specify which credential is being requested: `credential_identifier` or combination of `format` and credential format specific `credential_definition`. We (Microsoft) are currently implementing VCI and...

Issuer metadata pagination / limiting the number of credential_configurations_supported being returned

1

If the Issuer has a large number of credentials it supports (thousands or millions), and if it returns all of them to the wallet when the wallet fetches the metadata,...

where `type` values of the transaction data and content specific to that type should be defined

5

related to #156. 1. there have been conflicting comments whether type values should be "open-ended" so that e.g. each open banking jurisdiction for authorization of payments or data sharing and...