Sabnock
Sabnock
Could you please provide some further details? Such as your version of Python and what it is you're specifically trying to do?
Tried looking into this actually. Changing it from `bytes32(hex"1337")` to `bytes32(uint256(1337))` will get it further in the code but it will still fail on [this check](https://github.com/foundry-rs/forge-std/blob/1c418a04f6f6b002a1631838da5761641391858b/src/Test.sol#L587). Also tried it against...
This is a very rough draft of the implementation. Things to be most likely added/modified: - Tests (could include the migration of the FYToken tests to Foundry also in this...
> > We could make an interface or abstract contract for ERC-5095 like the others in yield-utils-v2 > > > @Sabnock01 what do u mean by this? i'm interested Pretty...
We can rework this to be a meta issue on cast refactoring if you guys would like.
> Note that this works in `--via-ir`. Good to know! This is much easier and `via-ir` no longer takes 45 minutes to build files. However, is there any reason why...
Will take this one.
`initialize` is pretty common for proxies so I'd change `init`
> There is a failing test, which I don't think is related to this PR: > ``` > 2023-02-23T15:37:08.3105748Z Failing tests: > 2023-02-23T15:37:08.3105923Z Encountered 1 failing test in src/test/YieldMath.t.sol:YieldMathTest >...
A reasonable compromise here in my opinion would be to change the folder to be `L1Addresses` [suggested earlier](https://github.com/ethereum-optimism/superchain-registry/issues/3#issuecomment-1707414711) without renaming anything in all the individual `*.json` files but also adding...