Saadi Save

Results 38 comments of Saadi Save
trafficstars

> The original suggestion for all of this from @SaadiSave had the following additional arguments: > ``` > -Clto=fat -Cembed-bitcode=yes > ``` > @SaadiSave should we use those? It is...

Okay, I'll begin as soon as possible. Will you be committing to main or merging any PRs soon? I'd like to reduce merge conflicts, so I'll start with the latest...

Firstly, but I think that the way modules are structured is rather unidiomatic and makes the code hard to read. For example: ```rust use juliaup::{ command_selfchannel::run_command_selfchannel, command_selfuninstall::run_command_selfuninstall, command_config_backgroundselfupdate::run_command_config_backgroundselfupdate, command_config_startupselfupdate::run_command_config_startupselfupdate, command_config_modifypath::run_command_config_modifypath,...

Possible refactored module tree: ![image](https://user-images.githubusercontent.com/53120037/178505680-bb775468-d66d-4fe4-816b-af8dc027cc5d.png) As text: ``` crate juliaup_skeleton ├── mod command: pub │ ├── struct Add: pub │ ├── struct Api: pub │ ├── trait Command: pub │...

@davidanthoff, what is your opinion on this proposal?

Okay. Meanwhile, I will begin planning the PRs.

@uncomfyhalomacro I have finished planning the PRs. - PR 1: Reformat and lint 1. Run `cargo fmt` 2. Lint with clippy 3. Add both to CI - PR 2: Refactor...

@davidanthoff do I have the green light?

> @SaadiSave I guess open the PRs. They usually are lost from multiple issues hanging around. Okay, I shall open the first PR shortly

I can confirm that this is reproducible as of CLion `2021.3.4`, Rust `1.59`, axum `0.4.8`, and IntelliJ-Rust `0.4.166.4486-213` on Ubuntu `20.04.4 LTS` Are there any updates as to why this...