Spencer Wilson

Thanks very much for this gargantuan effort @ashman-p @ducnguyen-sb! Since this is such a big PR, I'm going to review a few files at a time and occasionally leave a...

(As I understand it) the purpose of `liboqs` is not to provide an API to software developers or the general public, but to provide (relatively) clean and efficient implementations of...

> Thanks for disabling keygen/verify by default. But as XMSS/LMS are also disabled by default, it seems there's not a single CI run for these configs now... Please correct me...

First stab at adding CI is up in #1692 @ashman-p @baentsch @ducnguyen-sb.

I'll rebase on `main` to sort out the merge conflicts; looks like they're related to my recent work.

Preserving @cryptojedi's input (via @dstebila) so it doesn't get buried in a (hopefully) soon-to-be-merged PR. > I checked with @cryptojedi and he says that after this there shouldn't be any...

As of 2024-04-23, the HQC AVX2 implementation [has been updated ](https://pqc-hqc.org/implementation.html) to address the known constant-time bug, so (hopefully) patching will no longer be required.

Sorry for the merge conflicts introduced by https://github.com/open-quantum-safe/liboqs/pull/1832, @bhess. I think it's a straightforward resolution: just move the AES callback structure updates to the new [`aes_ops.h`](https://github.com/open-quantum-safe/liboqs/commit/26feef2e8a7863cc4f479e3ac387443beec06791/src/common/aes/aes_ops.h) file.

Completed (for SHA256) in #1650.

On my way to file a CMake bug report, I noticed this commit: https://gitlab.kitware.com/cmake/cmake/-/commit/5cc8a69867ac42333a656607d90059a6db823abd. Newer version of CMake take the (reasonable, in my opinion) approach of trusting a user-defined `OPENSSL_ROOT_DIR`...