Spencer Wilson
Spencer Wilson
> My interpretation of the sequence leading up to the CI failure (github): (cc: @ryjones ) > > The test that fails is triggered by > > https://github.com/open-quantum-safe/liboqs/blob/a5ec23cf19763d36a558b8358345823ae45d57e5/.github/workflows/release-test.yml#L15 > (well,...
The CI failures were occurring because oqs-bot didn't have sufficient permissions. (I'm guessing its permissions were lowered silently during the move to Enterprise or some other recent change.) After https://github.com/open-quantum-safe/tsc/pull/30/files,...
I'm all for enabling it. > I note they say their own routines use this feature too. Looks very useful, though we need to strive for all implementations being constant-time...
@cothan thanks for volunteering to take a look at this. Are you OK with my assigning the issue to you? EDIT: never mind, I missed the self-assignment... thanks again!
Seconding this as a priority; I've recently had to ask outside contributors to fix DCO in [two](https://github.com/open-quantum-safe/liboqs/pull/1747) [different](https://github.com/open-quantum-safe/liboqs/pull/1758) PRs that were otherwise ready to merge.
I agree that the `void` return is less than ideal. However, I believe this is a legacy of the [DRBG that NIST provided](https://github.com/open-quantum-safe/liboqs/blob/7a6df815bbb218e4490064a1558b09edea410576/src/common/rand/rand_nist.c) for submissions to the PQC standardization process,...
It would be great to hear a little more about your use case and if that latter option would be helpful for you. (And if it would be helpful enough,...
> > It would be good if PR could confirm this: OQS either uses and relies on CI (after getting it right) or it skips/does away with it and merges...
I have talked to GitHub about getting into the Arm private beta, but it was pending some administrative work to get our account upgraded to Enterprise. Pinging @ryjones for any...
> I have talked to GitHub about getting into the Arm private beta, but it was pending some administrative work to get our account upgraded to Enterprise. Pinging @ryjones for...