Spencer Wilson

@ueno Are you interested in continuing to work on this? Just wondering whether to leave this PR open for further development or to close it. Either way, it will remain...

For some reason I'm not able to view logs for the failing CI jobs: only a message that says "this job failed". I'm going to rerun them and see if...

Functionality-wise, this looks OK to me. Thanks, @ueno! It would be nice to test the `OQS_*_set_callbacks` API in CI somehow. Is this something that's feasible to do here, or is...

> @SWilson4 That is a good point. My plan was to add a Nettle backend and run CI [there](https://gitlab.com/gnutls/nettle), once their SHAKE interface has settled. Additionally/alternatively I could add a...

A few comments from an older review (addressed in-person with @praveksharma) slipped in. I think I've cleaned them all up; sorry for any confusion.

Thanks for the bug report! This appears to be a regression in CMake. I reproduced your error in a `kali-rolling` image with CMake 3.28.3. Everything worked fine, however, with CMake...

Hi @bencemali, thanks for the PR. It's correct that `liboqs` could call out to the `OPENSSL_cleanse` when built against OpenSSL. I'm not an expert on OpenSSL inner workings, but it...

> Hi @bencemali, thanks for the PR. It's correct that `liboqs` could call out to the `OPENSSL_cleanse` when built against OpenSSL. I'm not an expert on OpenSSL inner workings, but...

My two cents: > OpenSSL guarantees that `OPENSSL_cleanse` always works and is not optimized out, it is an industry-wide used, trusted, and reviewed solution.The motivation behind this pull request is...

OK, I just took a closer look through the OpenSSL repo and found what appear to be [assembly](https://github.com/openssl/openssl/blob/openssl-3.3.0/crypto/x86_64cpuid.pl#L243) [implementations](https://github.com/openssl/openssl/blob/openssl-3.3.0/crypto/x86_64cpuid.pl#L243) of `OPENSSL_cleanse`. I had missed these originally because they're contained in...