SSE4

Results 167 comments of SSE4

master: ![image](https://user-images.githubusercontent.com/870236/136332041-78f5f899-46e6-476d-8e43-23d7101a7e04.png) my branch: ![image](https://user-images.githubusercontent.com/870236/136332120-c6a3dc26-c08a-4513-95b2-0839bb9ad1e3.png)

> Hi! > > Out of curiosity, is there any reason for implementing this using WinAPI and not simply checking for the `"TERM"` environment variable? to be honest, I am...

just in case, ssome more screenshots with other terminals Cygwin terminal: ![image](https://user-images.githubusercontent.com/870236/138498342-dcb8c65e-0be9-4511-b4f8-920141af9d63.png) cmd.exe: ![image](https://user-images.githubusercontent.com/870236/138498565-d98fc51f-9f9f-4735-a614-496d92627503.png) powershell: ![image](https://user-images.githubusercontent.com/870236/138498612-666b66c6-1ff8-4518-9b8e-ca3c343bc906.png)

unfortunately, it seems like I am not so good with mocks and don't know to properly mock modules like `msvcrt` or `ctypes`. I've tried to play a bit with `mock.patch`...

> Tests implemented on [this PR](https://github.com/SSE4/colorama/pull/1), if @SSE4 is happy with that and merges to his fork I think they will show up on here. > > It was a...

@3tilley there are some failed tests, can you take a look?

> @SSE4 can you permission me to push to that branch to just make it a bit quicker? sure, I have invited you as a collaborator to my fork. check...

I've just checked #226 doesn't fix that particular issue for me. I can take a look and let you know on my findings.

well, if I remove `import colorama` it fails with the same error for me: ``` Traceback (most recent call last): File "C:\conan\colorama\test_colorama.py", line 3, in print("\N{Heavy Check Mark} check mark")...

I think the right fix to detect a proper IO encoding should be done somewhere around here: https://github.com/python/cpython/blob/db693df3e112c5a61f2cbef63eedce3a36520ded/Python/fileutils.c#L898 may require some collaboration with MSYS and Python developers to make it...