Jonathan Chan Kwan Yin

Can you enable debug logging? Set debug.level to 2 in pocketmine.yml

yes, because the player doesn't have an account yet. you have to spend or get money the first time to actually initialize the account.

> Why is the account not initialized when a player joins? because players may have multiple accounts. For example, if the world schema (#10) is used, the player accounts do...

Is https://github.com/onelson/jq-rs/blob/5a50b86010377178672266bcafd7bd925ac252c6/src/lib.rs#L177-L180 a consequence of this issue? An empty input yields an empty output because the program is never run for any input, which should not be a special case.

nit: adding tests to CI does not impact features; commit title prefix should be `chore`/`ci` instead?

I replaced the apiserver list request with a label-indexed pod cache in the pull request here: https://github.com/SOF3/kubeadmiral/pull/1 I wrote a few simple unit tests but I am not very confident...

How often do we need to unmarshal the template? It saves the cost of deserializing them every time federated object is updated (especially status-only updates), and it reduces memory footprint....

Let's review the `GetTemplateAsUnstructured` usages one by one: - federate: It is only used to retrieve the GVK of the federated object. Could we just parse it as a `metav1.GroupVersionKind`...

`[]int{2, 3}` is explicitly defined to have a capacity of 2. From the [Go language specification](https://go.dev/ref/spec#Composite_literals): > A slice literal describes the entire underlying array literal. Thus the length and...

There are several things we can improve about errors altogether: - Interaction with tracing - Structural errors - Exposing errors to metrics - Unify error format We can improve all...