Jonathan Chan Kwan Yin

Results 363 comments of Jonathan Chan Kwan Yin

Better not. The contributor list is for display only.

Actually refers to virion dependencies of plugins too.

Dependency resolution is complicated indeed. Pushing for virion v3 is probably the easier solution.

Right, then it has to be determined during submission.

the /get/plugin-name/dev looks up the unique release name from the released plugin list. the dev build is retrieved from the repo used to release the plugin.

Sure, if anyone wants to implement it. But plugins do not have the semantic versioning like virions do, so the mechanism is slightly different (but probably even simpler). With that...

Downloading a version doesn't make sense. If it is versioned, it is already released.

reproduced with jaeger-remote-storage using badger memTable backend with v3.2103.5 on Linux 5.4.56 in container: ``` unexpected fault address 0x7f3eb7a1c000 fatal error: fault [signal SIGBUS: bus error code=0x2 addr=0x7f3eb7a1c000 pc=0x46f32f] goroutine...

It is simply because the thread does not try to catch errors, thus never sending SqlErrorResult properly