SNeedlewoods

It was discussed in #no-wallet-left-behind. If you look at these three links for example, you see the functions are out of order: https://github.com/monero-project/monero/blob/master/src/wallet/api/wallet2_api.h#L142 https://github.com/monero-project/monero/blob/master/src/wallet/api/unsigned_transaction.h#L44 https://github.com/monero-project/monero/blob/master/src/wallet/api/unsigned_transaction.cpp The feedback was: >I think...

The Wallet API PR is actually not based on this. I have another local branch for adding comments which is based on this. The idea was: if this gets merged,...

> I like a quick meeting once a week at a predictable time, with no obligation to fill up the entire time slot if there isn't anything to discuss +1...

Thanks, I should make another PR for https://github.com/monero-project/monero/pull/9464 based on release, that's where I added those `WalletListener` callback functions, I think once that is merged the "marked override" complains for...

>What downstream systems use wallet2_api.h (outside of the official GUI)? If things work out as proposed [here](https://github.com/seraphis-migration/wallet3/issues/64) (in step 2), the `wallet2_api.h` will also be used by the wallet-CLI and...

Unfortunately I can't give you an ETA, because #9464 needs more reviews/approvals from others, but for my part I'll try my best to resolve review comments ASAP. I'm glad to...

I agree, will add it. Thank you.

# Update ## Tests Started working on tests on a new branch which helped finding the following minor issues with the Wallet API so far: - [ ] `bool ssl`...

Two more things: 1. We have `walletExists()` in `WalletManager` [src](https://github.com/monero-project/monero/blob/c4488ab10790316eacce6f059cc0721a0f7a2c62/src/wallet/api/wallet2_api.h#L1745), but that only returns true if `keys_file_exists`, which is not sufficient for [this case](https://github.com/monero-project/monero/blob/c4488ab10790316eacce6f059cc0721a0f7a2c62/src/simplewallet/simplewallet.cpp#L3901-L3928) in simplewallet, where we differentiate between...

# Identified conflicts/overlaps The following table should contain all the overlaps with #9492 (also referred to as "vthors PR" or "Offline Signing PR"), with a summary below of which actions...