rusat

I have updated the PR with the following fixes: removed the unused _vars binding as suggested. adjusted the UI test as per the review (removed the unnecessary // build-fail comment...

thanks for asking and happy to explain and answer your questions i used skip_binder() because i only wanted to check the inner type that actually reaches the FFI boundary. The...

I see your point about using the fluent error messages instead of a raw string. I will take a look at the other arms and update this one to follow...

that makes sense. the current output only shows &(), while the span highlights the full unsafe &a (). I agree that the diagnostic should refer to the same type for...

Thanks for the detailed feedback I have updated the PR to address both concerns: 1. i changed the diagnostic to show the full type unsafe &a() instead of just the...

hi i have squashed the commits and cleaned up the history as requested. these are the updates included in the final commit: 1. unified the diagnostic wording and switched to...

I ran ./x.py test tidy for clean format file checking because this automatically runs after running git push. So, to double check formatting i ran ./x.py test tidy and it...

compiler/rustc_lint/src/types/improper_ctypes.rs. For this file when i remove the last newline it shows me this while running tidy. so for this only i gave the the newline so that tidy test...

I have checked the tidy issues and fixed them. Also fixed the newline and whitespaces issues. Please verify now.

Thanks for the guidance and for taking the time to walk me through the review. I understand the expectations better now, and I will make sure to study the surrounding...