cloud-sdk-ios-fiori icon indicating copy to clipboard operation
cloud-sdk-ios-fiori copied to clipboard

ObjectHeader footnote text is cut when user changes dynamic text size

Open dzmitry-antonenka-sap opened this issue 2 years ago • 1 comments

Describe the bug ObjectHeader footnote text is cut when user changes dynamic text size

To Reproduce

  1. For Examples.xcodeproj replace content of the ContentView.swift with following code: ` import FioriCharts import SwiftUI import FioriCharts import FioriSwiftUICore import FioriCharts import FioriSwiftUICore import SwiftUI struct ContentView: View { var body: some View { BrokenObjectHeader() } }

struct BrokenObjectHeader: View { var body: some View { NavigationView { NavigationLink("Open details") { ScrollView { VStack(spacing: 30) { ObjectHeader { Text("Some title text explaining something") .font(.fiori(forTextStyle: .title3)) .foregroundColor(.preferredColor(.primaryLabel)) .fontWeight(.black) } subtitle: { Text("Some author name") .font(.fiori(forTextStyle: .body)) .foregroundColor(.preferredColor(.secondaryLabel)) .fontWeight(.regular) } footnote: { Text("2 days ago") .font(.fiori(forTextStyle: .subheadline)) .foregroundColor(.preferredColor(.tertiaryLabel)) .fontWeight(.regular) } } } } } } } `

  1. Launch the app
  2. Press "Open details" button and increase dynamic text size to extra extra large size using environment overrides
  3. Press "Back"
  4. Press "Open details" and decrease dynamic text size to extra extra small size using environment overrides
  5. Observe footnote clipped

https://user-images.githubusercontent.com/104075283/164249184-7c9c7878-6d4c-4809-a4d5-2ec32978f9aa.mov

Expected behavior The text should be fully rendered with matching dynamic size

Screenshots Simulator Screen Shot - iPhone SE (2nd generation) - 2022-04-20 at 19 38 06

Mobile (please complete the following information):

  • Device: iPhone SE - 2nd generation (Simulator)
  • OS: iOS 15.4
  • Swift Package Product: FioriSwiftUICore
  • Swift Package Version: 2.1.0, main branch, commit 0786a130dc8cf6c09cf3d05ba2da288c1194b190
  • Xcode Version: Version 13.3 (13E113), toolchain Xcode 13.3
  • FioriSwiftUI / cloud-sdk-ios-fiori 2.1.0

dzmitry-antonenka-sap avatar Apr 20 '22 14:04 dzmitry-antonenka-sap

@shengxu7 Can you take a look at this issue when you get a chance?

billzhou0223 avatar Apr 20 '22 19:04 billzhou0223