Sebastian A. Spindler
Sebastian A. Spindler
> Thank you both for noticing this and for the suggestions. I've updated the docs accordingly. Thanks for the changes, looks good to me now! Not sure why the workflows...
Since this PR contains the code from #38994, which does not have its own positive review yet, it probably makes sense to close that PR and integrate the "Fixes #38988"...
Is `P` actually a prime ideal in the ring of integers? The discriminant of `K` is divisible by 3, so there should be some ramification - it seems that the...
It seems sufficient to also check the ramification index of the ideal returned by Pari; I'll work on a fix.
Turns out it is a bit more involved to solve, since the ramification index of Pari prime ideals is taken relative to the prime number in Z they lie above;...
But then, following the description [here in the documentation](https://pari.math.u-bordeaux.fr/dochtml/html/General_number_fields.html#se:idealismaximal), this seems to be an issue on the Pari side since the underlying rational numbers are actually primes. @AurelPage Do you...
> This is now fixed on master (commit `e300d967c6d4827a8717eb5d828`). Thanks for the report! Great, thanks for the fix!
I'll review this once the necessary checks have completed.
Let me know (e.g. by commenting here) once you think this is ready for another full review; in the meantime, Lint recognized some whitespaces in the blank line 302.
> ready for review Great, I'll review it again when I find the time for it; this will probably not be before Friday though.