Ryan Woods

Fix Country factory states_required attribute

11

**Description** Resolves issue: https://github.com/solidusio/solidus/issues/4270 Some tests were modified to give a state with the address parameters as they used a country which will now get the states_required attribute of true,...

Fix Spree::Api:LineItemsController#create handling validation errors

10

Spree::Api:LineItemsController#create calls #add on an OrderContents instance which eventually call #save!. This raises errors if validation fails. #create was not handling these validation errors. In fact, it had an if...

Fix AddPaymentSourcesToWallet changing default when reused

4

Fixes issue #4004 [1] PR #2913 [2] changed how the new default WalletPaymentSource was set, from using the last one found/created * within the Order's PaymentSources to the user's last...

Fix TestingSupport Country Factory states_required

1

The mentioned attribute is commented out due to issues with Solidus' tests. https://github.com/solidusio/solidus/blob/a6c2ceeb2ee6bff832080ebb11773f7b6e4c2df0/core/lib/spree/testing_support/factories/country_factory.rb#L23-L24 This should be fixed so that anyone developers can use the factory and not have to modify...

Some gateways want the gateway order_id to be consistent for transactions on the same order

1

**Issue** When a payment gets processed it provides an `order-id` in the `gateway_options` to go to the gateway. Because of issue, https://github.com/spree/spree/issues/1998 the sent `order-id` [was changed to be unique](https://github.com/spree/spree/commit/861512f5d2807efc71c35e1b85ae871aa060fd41)...

## Summary In order to order to be able to update LineItem's validations to stop allowing a quantity of zero, we need to remove code that saves LineItems with a...

Single word names are duplicated during PayPal transactions

1

**Current behavior** Single names entered in the Solidus shipping address form become duplicated with a space between during PayPal transactions. (I have not checked Venmo or CreditCard). This seems due...

Add .env to .gitignore

1

## Summary This file is useful for testing: - https://github.com/solidusio/solidus_paypal_braintree/blob/920a4e7da8e6b2cb441ca1400c8c3df0832aa01e/spec/support/gateway_helpers.rb#L8-L15 It was removed from the file here: - https://github.com/solidusio/solidus_paypal_braintree/pull/289/commits/f9dc06d8a97fb23ad61959142c5d49d6a6960a89 ## Checklist Check out our [PR guidelines](https://github.com/solidusio/.github/blob/master/CONTRIBUTING.md#pull-request-guidelines) for more details. The...

Update outdated README.md factory example

4

## Summary These factories were recently moved when making the extension complaint to solidus_dev_support: - https://github.com/solidusio/solidus_paypal_braintree/pull/289/commits/f9dc06d8a97fb23ad61959142c5d49d6a6960a89 ## Checklist Check out our [PR guidelines](https://github.com/solidusio/.github/blob/master/CONTRIBUTING.md#pull-request-guidelines) for more details. The following are mandatory...

Does not support Braintree Risk Threshold Rules well

1

Braintree comes with free basic fraud protection. One of the tools is Risk Threshold Rules (velocity checks) [1]. Many of the fields [2] cannot be used as the extension is...