RustPython icon indicating copy to clipboard operation
RustPython copied to clipboard

Update `uu.py` and `test_uu.py` from CPython v3.12.0

Open kingiler opened this issue 1 year ago • 11 comments

Pass more unit tests in test_uu.py

kingiler avatar Feb 09 '24 14:02 kingiler

Usually, the commits that have anything to do with RustPython are separated from the commits that contain changes made in CPython by CPython developers.

fanninpm avatar Feb 09 '24 15:02 fanninpm

One of the failing test is test.test_importlib.builtin.test_loader.Frozen_LoaderTests.test_module. No idea how the change is related to the failing test yet.

youknowone avatar Feb 10 '24 02:02 youknowone

@kingiler is this intended to be closed or accident?

youknowone avatar Mar 01 '24 12:03 youknowone

@youknowone It was an accident. I messed up with the git force push commit before.

kingiler avatar Mar 01 '24 13:03 kingiler

Now I found the potential cause for the issue. Comment out introducing of warnings._deprecated(__name__, remove=(3, 13)) in uu.py would pass the test_importlib test.

kingiler avatar Mar 01 '24 13:03 kingiler

@youknowone I have a strange issue that this PR does not sync with my branch at https://github.com/kingiler/RustPython/tree/update_uu, do you know what is happening here?

kingiler avatar Mar 01 '24 14:03 kingiler

it happens sometimes when you pushed it during parts of github is out of service. you can edit the last commit by git commit --amend without any actual change to generate a new commit id and push force to update it.

youknowone avatar Mar 12 '24 05:03 youknowone

If removing deprecated warning fix importlib problem, it will be the best. uu will be removed in 3.13. Probably not worth to spend too much effort though.

youknowone avatar Apr 21 '24 19:04 youknowone

I somehow debug that the issue comes from email library importing the deprecated uu library. This PR may have to wait until email is updated.

kingiler avatar Jun 20 '24 22:06 kingiler

@youknowone should we closed this PR and make a notice on update list that uu is deprecated in 3.13?

kingiler avatar Jun 20 '24 23:06 kingiler

@kingiler I'd like to merge it if it is easy to fix. Otherwise let it just be removed later.

youknowone avatar Jun 21 '24 13:06 youknowone