RustPython
RustPython copied to clipboard
Introduce PyAtomicRef and impl for PyObject.typ
@youknowone correctness and performance check?
Feel free to ignore those Clippy failures. @youknowone likely missed them in https://github.com/RustPython/RustPython/pull/3817.
#3970
Is this approach safe as we manaully require the reference to the pytype cannot across between the frames. Most of the case we use the pytype is either using pytyperef or using the reference immediately. @youknowone
Oh, I missed your last push. I will check the changes soon.
(using PyAtomic instead of AtomicCell would fix the provenance errors in miri)
(using PyAtomic instead of AtomicCell would fix the provenance errors in miri)
let me try
Also, vm.frames
should definitely be made private now, since it's now a safety thing that a frame cannot be popped off the frame stack + dropped before it's fully done running.
(using PyAtomic instead of AtomicCell would fix the provenance errors in miri)
let me try
Don't know why but seem like failing the compile when threading is off, any mistake about how to use PyAtomic? @coolreader18
(using PyAtomic instead of AtomicCell would fix the provenance errors in miri)
let me try
Don't know why but seem like failing the compile when threading is off, any mistake about how to use PyAtomic? @coolreader18
nevermind, it just the name conflict
@coolreader18 @youknowone review?