formats

formats copied to clipboard

der: why don't more ASN.1 types support conversion to `Any(Ref)`?

11

Hi there! I'm new to the RustCrypto libraries, so if I'm holding them wrong and there's a smooth way to go from one to the other, please point it out...

RickyDaMa

I'm only working with `SignedData` & `SignerInfo`, I haven't checked the other builders, but these methods are all infallible, why do they return `Result`? - `SignedDataBuilder::add_digest_algorithm` - `SignedDataBuilder::add_certificate` - `SignedDataBuilder::add_crl`...

RickyDaMa

I'm not sure how I'm supposed to access the underlying error when it gets dropped on line 415: https://github.com/RustCrypto/formats/blob/cfacd3efed49b28f38e69612221b8af5f33a5cbf/cms/src/builder.rs#L400-L419 For my use case, I'm signing remotely using Google KMS, and...

RickyDaMa

der: breaking changes in `ObjectIdentifier` and `AnyRef` with `tag_mode = IMPLICIT`

8

So I was just trying to change my application from my self-made support for private tags to the upstream support in the release candidates. (Thanks @tarcieri and @turbocool3r for following...

kamulos

der: Error stacktraces

4

https://github.com/RustCrypto/formats/blob/bd840638835fcf66c4ffc3baed6d7c3b727c4ef3/der/src/decode.rs#L26-L28 I think associated `Error` would be useful inside `Reader` trait. [^1] ## Motivation To prove usefulness, suppose we want to return annotated errors with `.field` stacktrace. Example of such...

dishmaker

der: add `EncodeValueLenCached` wrapper

2

Sometimes, when encoding big DER structures, `value_len` gets called many times. In order to limit amount of recursive calls, this wrapper caches the computed length, until the value gets encoded.

dishmaker

fix(x509-tsp): add proper no-std support

1

# x509-tsp: Add proper no-std support ## Summary The `x509-tsp` crate does not properly support no-std environments, despite being part of the RustCrypto ecosystem where no-std support is a core...

0kPN1

cms: Added a test for BER-CMS

3

This is my real-world test of a BER encoded CMS message using indefinite lengths. I removed the content, but kept the structure. This kind of messages is sent by EJBCA...

bkstein

der: add `ClarifyWriter`

1

I have a pretty well-written `#[cfg(feature = "clarify")]` - gated writer that pretty-prints DER. Proposal: To add `Encode::to_hex_clarify`, that annotates tags and types. Example of PKCS#15: ```xml 30 3E 30...

dishmaker

der: use Cow for *Ref types

3

Following https://github.com/RustCrypto/formats/pull/1778#issuecomment-2840198645, we need to investigate why Cow does not work. One major issue is that `Clone` is implemented on `Ref` types. https://github.com/RustCrypto/formats/blob/217b6eff7bf1b15d4fea21a3a186c2faee4a4344/der/src/asn1/ia5_string.rs#L37-L40 which collides with (if i remember correctly):...

dishmaker