formats

formats copied to clipboard

Changes: - add inner newtype `UnusedBits` - calculate `bit_length` on the fly

dishmaker

Partial fix for: - #2062

dishmaker

`to_system_time` overflows if encoded timestamp can't be represented as i64 (usually)

dshulyak

The way `SetOfVec::insert` is implemented results in the internal structure containing an unsorted duplicate value, because it first inserts the value, and then check whether it's a dupe while simultaneously...

roblabla

Is there a way to add an unsigned value after the signature ?

1

Basically I need to add a TSA to my CMS signature and include it into the unsigned data.

mstjr

remove repetitive word in comment

reddaisyy

der: Tracking issue for deoptimiztions since `v0.7`

5

Due to BER: - using `ber` features makes DER reader slow (about 20% slower) - `read_nested` now includes primitive `DecodeValue`s too (added in #1877) (partial fix in #1916) - ~indefinite...

dishmaker

der: add `new` and derives to SequenceRef

2

This is a reopening of #1977 which was closed because there was too little explaination. The motivation for adding the derives is that I cannot use `SequenceRef` in my structs...

kamulos

After PR: - https://github.com/RustCrypto/formats/pull/1889 most cases now return error position, but few untreated errors remain, for example: https://github.com/RustCrypto/formats/blob/3ee0028ef967b0831df6fc6338e2620ea03efd43/der/src/asn1/generalized_time.rs#L112 https://github.com/RustCrypto/formats/blob/858f3af9df8398cb456ebe05b41f82e0335e66d8/der/src/asn1/integer/uint.rs#L330 https://github.com/RustCrypto/formats/blob/858f3af9df8398cb456ebe05b41f82e0335e66d8/der/src/asn1/oid.rs#L19

dishmaker

der: clarify writer: add pretty-printing DER hex with comments

1

Resolves #1835 I made sure it does not add any runtime overhead, even when using the `"clarify"` feature. This PR is initial support. In future I'd like to add `Sequence`...

dishmaker