rodio

rodio copied to clipboard

https://github.com/RustAudio/rodio/blob/22d90e71d8d635bb777f5c0f9ca95be843b02ff3/src/source/blt.rs#L58 The filter method Billinear transform, is an implementation detail that should not appear in the API, since that limits future change. That alone is not a reason to rename...

yara-blue

DataConverter is a subset of SamplesConverter

2

They both provide a way to lazily preform `CpalSample::from_sample` on all samples. SampleConverter implements Source DataConverter none. We should remove DataConverter in favor of SampleConvertor.

yara-blue

Exactly the same code just another word. Question: Do we keep skippable or stoppable? my preference goes to stoppable since skipping is a proparty of stopping a source early with...

yara-blue

Remove field access from EmptyCallback

1

There is no reason why this: https://github.com/RustAudio/rodio/blob/70c236c7ac495b9ccb82716ffba06cb3fe5fa44c/src/source/empty_callback.rs#L10 is public. Same for the callback. The struct should only be made by the factory function `EmptyCallback::new`.

yara-blue

Mp4 extensions do not have any real value: https://en.wikipedia.org/wiki/MP4_file_format#Filename_extensions Therefore the mp4 constructor can just pass mp4. https://github.com/RustAudio/rodio/blob/70c236c7ac495b9ccb82716ffba06cb3fe5fa44c/src/decoder/mod.rs#L314 This makes the function more in line with the rest (no need...

yara-blue

Popping when a "silent" source is appended to a Sink

2

I have some music after which I have appended some silence. I noticed this now causes popping sounds. I'm running Linux ~I haven't tested other OSes~ also reproduced the same...

alexheretic

Incorrect total_duration while using symphonia features

1

While using rodio with symphonia features enabled values reported by [Decoder::total_duration](https://docs.rs/rodio/latest/rodio/decoder/struct.Decoder.html#method.total_duration) are incorrect. It works fine while using other backends. Calculating it with symphonia directly also return correct value. Minimum...

Kamil729

Make accidentally dropping OutputStream impossible

14

This adds a drop bomb to OutputStream. Dropping a OutputStream will panic (unless we are dropping as part of unwinding). Technically OutputStream is now a run time enforced linear type....

yara-blue

Perceptual loudness | analysis sources

5

With Rodio taking on more and more dsp like features it could be interesting to add a layer that analyzes the perceptual loudness. It should be relatively simple as an...

yara-blue

Release 0.21.0

14

Chores: - [ ] check upgrade guide - [x] write announcement - [ ] put release date in CHANGELOG - [ ] update examples link in README

yara-blue