DataConverter is a subset of SamplesConverter

Open yara-blue opened this issue 1 year ago • 2 comments

They both provide a way to lazily preform CpalSample::from_sample on all samples. SampleConverter implements Source DataConverter none.

We should remove DataConverter in favor of SampleConvertor.

Sep 16 '24 16:09 yara-blue

SampleConverter? I cannot find it... Besides, if we keep DataConverter I would rename it to SampleFormatConverter.

Jan 05 '25 11:01 PetrGlad

SampleConverter? I cannot find it... Besides, if we keep DataConverter I would rename it to SampleFormatConverter.

typo by me, it is called SamplesConverter

Jan 05 '25 12:01 yara-blue