manipulation
manipulation copied to clipboard
Commit sha in solutions_sha.txt is wrong after squash-and-merge PRs
For a PR to manipulation-solutions that uses squash and merge, the single commit that is commited to master will have a brand new sha value (it won't be any of the sha's in the PRs commit history). Therefore, the workflow in README.md in the solutions repo is wrong (one has to first merge to manipulation-solutions, not the other way around as the README suggests).
A current solution is:
- Merge the solutions to
masterin themanipulation-solutionsrepo - In the PR in the
manipulationrepo: Runsolutions/install.pyto generate asolutions_sha.txtwith the correct commit sha - CI/tests will now run in the PR in the
manipulationrepo for the newly commited solutions.
The problem with this is that if the tests fail, then one has to go back and update the manipulation-solutions repo again. But I don't really know if there is a way to avoid this.