Ruben Verborgh

Results 1034 comments of Ruben Verborgh

Thanks, @rubensworks, great to have this. > Unless I made some mistake, this is backwards-compatible, so no major version change is needed for this one. > I think it's safe...

> The media type will actually remain the same. That… is something we should look into. I don't think the definition`text/turtle` can retroactively be changed in that way. Yes, `text/html`...

> Related do this, would you want to keep 1.1 support in the next major version (where 1.2 features are rejected)? That depends on the answer of the first point....

Issue raised at https://github.com/w3c/rdf-star-wg/issues/141 Rejection tests are exemplary only; they are not the full range of rejected output.

> this is a breaking change Fingers crossed that the RDF WG sees it that way indeed 😉 Excellent work, @rubensworks.

All good, comments were minor; do proceed.

Feel free to already test and provide feedback; perhaps some points before this PR is merged. ## Improvements - The `apply_custom_configuration` (https://github.com/zigpy/zha-device-handlers/pull/3701/files#diff-8c13a1ac582c2c486609043c4ca29ce34c03f0a9e07000e97800f953921817d7R38) does not seem to be fired / work...

Thanks @TheJulianJES for looking at this! > I'll need to go through this properly when I find some free time, but one thing: `Bus` shouldn't really be needed anymore. I...

Ready from my side. Dozens of devices been working without issue for months, if that counts as a test. @TheJulianJES?

> Considering this: what do you think of the following abstract implementation sketch on configuration level I don't understand the interaction between the three options? Are they fully independent? In...