Ruben Verborgh
Ruben Verborgh
We can give it a go if the performance effect extends to other cases. An easy fix could be to set the buffer size to zero. Perhaps there's already sufficient...
The more I think about it, it should be: `constructor(whatever, context = DEFAULT_CONTEXT)` and `this.context = context;` with `DEFAULT_CONTEXT` a frozen object `{ token: null }` that we recycle.
@bergos > That may cause problems if someone else comes up with the same idea but with different properties. Indeed, and thanks for looking at this. That's the main reason...
Thanks @bergos! Based on your comment, may I suggest to @faubulous: * `source` * `tokenType` * `token` * `prefix` * `line` * `start` * `end` We should still retain backward...
@faubulous That's the one!
@bergos Doesn't fully make sense to me; some of those are not source attributes. Perhaps: ``` { tokenType, token, prefix, source: { line, start, end, }, } ```
I'll leave the decision to others.
I'm very unsure now why we have an object with a single property wrapping an object with all the other properties. We're now creating twice the objects, and object creation...
To be determined: does this depend on auth status?
Specifically, the RFC states: > The "Allow" header field lists the set of methods advertised as supported by the target resource. The purpose of this field is strictly to inform...